lib: replace --diagnostic-report-* with --report-* #27312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the code base the word `report` is almost only used to refer to the diagnostic report when it's a noun, and it's programmable interface `process.report()` it not prefixed, so `report` should be unambiguous enough to use without `diagnostic`.
nodejs-github-bot
added
the
c++
|
cc @nodejs/diagnostics |
gireeshpunathil
approved these changes
Apr 19, 2019
|
I wonder if for consistency this might be a good time to change a couple of the flag suffixes to something shorter like in #27306, i.e. |
|
@mscdex I think path.format({dir: 'test', 'name': 'report.json'}); // test/report.json on UNIX
path.parse('test/report.json');
// { root: '',
// dir: 'test',
// base: 'report.json',
// ext: '.json',
// name: 'report' }And, the API of process.report() still takes |
cjihrig
approved these changes
Apr 20, 2019
Co-Authored-By: joyeecheung <joyeec9h3@gmail.com>
joyeecheung
added
the
author ready
|
Landed in 94adfe9 |
joyeecheung
added a commit
that referenced
this pull request
Apr 22, 2019
In the code base the word `report` is almost only used to refer to the diagnostic report when it's a noun, and it's programmable interface `process.report()` it not prefixed, so `report` should be unambiguous enough to use without `diagnostic`. PR-URL: #27312 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code base the word
reportis almost only used to refer tothe diagnostic report when it's a noun, and its programmable
interface
process.report()is not prefixed, soreportshould beunambiguous enough to use without
diagnostic.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes